Conversation
Add `dev-resolute` dependency group to allow development on Ubuntu Resolute, with `python-apt` version pinned to `3.0.0`.
This adds the ability to choose plugin groups to the Lifecycle service. This works differently from the default plugin setup in the Application, which is now deprecated in favour of this. Apps that move over will be rewarded with a happy fuzzy feeling and the ability to get the plugin group based simply on the BuildInfo object.
lengau
commented
Dec 15, 2025
lengau
force-pushed
the
work/CRAFT-4993
branch
from
2aa2065 to
9a1b84b
Compare
lengau
commented
Dec 15, 2025
lengau
commented
Dec 15, 2025
medubelko
requested changes
Dec 17, 2025
There was a problem hiding this comment.
Pull request overview
This PR introduces plugin group selection capability to the Lifecycle service, allowing applications to dynamically choose plugin sets based on BuildInfo. This deprecates the previous Application-based plugin registration approach in favor of a more flexible, build-specific plugin configuration system.
- Adds
get_plugin_group()method to LifecycleService for dynamic plugin selection based on BuildInfo - Implements witchcraft-specific plugin groups (MERLIN for Ubuntu ≤22.04 with Python, MORGANA for Ubuntu >22.04 with Rust)
- Deprecates Application.register_plugins() with a warning directing users to the new Lifecycle service approach
Reviewed changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| witchcraft/services/lifecycle.py | New lifecycle service implementation with plugin group selection logic for witchcraft |
| witchcraft/services/init.py | Registers the custom lifecycle service with the ServiceFactory |
| craft_application/services/lifecycle.py | Adds base get_plugin_group() method and plugin group setup logic in LifecycleService |
| craft_application/application.py | Adds deprecation warning to register_plugins() method |
| tests/integration/services/test_lifecycle.py | Adds integration test for plugin group setup with different plugin configurations |
| tests/spread/witchcraft/plugin-groups/ | Adds spread tests validating plugin group behavior on Ubuntu 22.04 and 24.04 |
| pyproject.toml | Updates craft-parts dependency to git source (temporary development dependency) |
| uv.lock | Updates lockfile to reflect git-based craft-parts dependency |
| docs/reference/services/lifecycle.rst | New documentation page for LifecycleService |
| docs/reference/services/index.rst | Adds lifecycle service to documentation index |
| docs/reference/changelog.rst | Documents new feature and deprecation in 6.1.0 changelog |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cmatsuoka
reviewed
Dec 17, 2025
Co-authored-by: Michael DuBelko <[email protected]> Signed-off-by: Alex Lowe <[email protected]>
Signed-off-by: Alex Lowe <[email protected]>
This updates distro-support so that Ubuntu 26.04 (resolute raccoon) is included when testing.
jahn-junior
approved these changes
Dec 19, 2025
Contributor
jahn-junior
left a comment
jahn-junior
left a comment
There was a problem hiding this comment.
LGTM! Consider my suggestions optional :)
Co-authored-by: JJ Coldiron <[email protected]> Signed-off-by: Alex Lowe <[email protected]>
lengau
commented
Jan 9, 2026
lengau
force-pushed
the
work/CRAFT-4993
branch
from
5861a46 to
8d3e4f4
Compare
Signed-off-by: Alex Lowe <[email protected]>
lengau
force-pushed
the
work/CRAFT-4993
branch
from
8d3e4f4 to
49c906f
Compare
medubelko
reviewed
Jan 9, 2026
medubelko
approved these changes
Jan 12, 2026
Collaborator
Author
|
Bypassing unrelated spread test failures. |
1 similar comment
Collaborator
Author
|
Bypassing unrelated spread test failures. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make lint && make test?docs/reference/changelog.rst)?This adds the ability to choose plugin groups to the Lifecycle service.
This works differently from the default plugin setup in the Application,
which is now deprecated in favour of this. Apps that move over will be
rewarded with a happy fuzzy feeling and the ability to get the plugin
group based simply on the BuildInfo object.
Fixes #966 CRAFT-4933